Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=816012 --- Comment #6 from Ralph Bean <[email protected]> 2012-05-07 12:49:11 EDT --- (In reply to comment #1) > Provisional review: open issues are the license. Formally, I should ask you to > inform upstream about the missing license file. However, since you actually > are > the upstream(?) I suggest that you fix it once and for all: > - Add a header with copyright and license info to all source files. > - Add the AGPL license file to the package, and include it in %doc > - Either include an overall copyright and license statement in README.rst, or > just include PKG-INFO in %doc which already has this. > > None of these are blockers. I will do a complete review as soon as you reply > to > this. I am in fact the upstream. :) (I should have mentioned that!) I put out a new version which resolves all the license ambiguity (Should be GPLv2+). I also updated the spec to be a little more specific when declaring directory ownership. Spec URL: http://threebean.org/rpm/python-virtualenvcontext.spec SRPM URL: http://threebean.org/rpm/python-virtualenvcontext-0.1.3-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
