https://bugzilla.redhat.com/show_bug.cgi?id=810676
Pavel Zhukov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |) | --- Comment #8 from Pavel Zhukov <[email protected]> --- (In reply to comment #7) > I found a few more small problems: > > You don't use chrpath, and indeed it doesn't seem to be needed, so the > dependency on it should be removed. Deleted > Please use cp --preserve=timestamps in the makefile, or simply cp -a, to > preserve the timestamps on installed source files and documents. Replaced cp with ${CP} = /bin/cp -a > %defattr is unnecessary with current RPM versions, but it's not forbidden so > you can keep it if you want. Removed > I think AUTHORS should go in the base package. Information about who the > authors are is logically connected with the license file. Fixed http://koji.fedoraproject.org/koji/taskinfo?taskID=4090332 Spec URL: http://landgraf.fedorapeople.org/packages/requested/aws/aws.spec -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
