https://bugzilla.redhat.com/show_bug.cgi?id=807479

Volker Fröhlich <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Volker Fröhlich <[email protected]> ---
I guess this also goes to EL5? Anyways, you can delete the defattr line.

%{_bindir}/spacewalk-setup-jabberd -- You can use the name macro on this line.

%dir %{_datadir}/spacewalk
%{_datadir}/spacewalk/*

can be simplified to %{_datadir}/spacewalk. On the other hand: This directory
is already owned by spacewalk-branding. You should probably just require it, if
that makes sense.

The syntax for the two pki directories can also be simplified, if I don't miss
something here.

I think the description is not perfect from a grammatical point of view.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to