https://bugzilla.redhat.com/show_bug.cgi?id=817311
--- Comment #12 from pcpa <[email protected]> --- (In reply to comment #10) > [!]: SHOULD Latest version is packaged. > > On the website I see the following: > http://miniupnp.free.fr/files/download.php?file=miniupnpd-1.6.20120509.tar.gz > > If it's too new for megaglest than current version it's ok. I preferred to package the release version, not snapshots. > [!]: SHOULD %check is present and all tests pass. > > There's a make check target in the makefiles. Thanks, I overlooked it, and did only check the Makefile generated by cmake, that should not have overwritten the toplevel one due to making the build in a subdirectory. Now added a proper %check. Also used %{name} and %{version} were sane, for source and patches. > $ rpmlint *rpm > miniupnpc-devel.x86_64: W: spelling-error %description -l en_US libminiupnpc > -> condominium > 4 packages and 0 specfiles checked; 0 errors, 1 warnings. > > Almost good! New package: Spec URL: http://fedorapeople.org/~pcpa/miniupnpc.spec SRPM URL: http://fedorapeople.org/~pcpa/miniupnpc-1.6-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
