https://bugzilla.redhat.com/show_bug.cgi?id=822896
Ralf Corsepius <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Ralf Corsepius <[email protected]> --- Some personal remarks: - Shipping the *.asc sig seems pretty meaningless to me. - I personally, would encourage you to use use %{?dist} in the %release tag. Sure, it's not mandatory and not using it helps avoiding rebuilds, if a package's contents doesn't change between Fedora/RHEL releases, however it also makes packages vulnerable to changes in rpm and to the file system layout between releases (A CentOS5's xxx-*.rpm is something entirely different than a Fedora 18's xxx-*.rpm, even though it's NEVR are identical). - I would recommend to use "install -m xxx" instead of "mkdir + cp" in %install. This helps to avoid bad surprizes related to ownership/permissions/umasks. -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
