https://bugzilla.redhat.com/show_bug.cgi?id=823948

Petr Pisar <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Petr Pisar <[email protected]> ---
Spec file changes:

--- perl-Lexical-SealRequireHints.spec.old      2012-05-22 09:21:13.000000000
-0400
+++ perl-Lexical-SealRequireHints.spec  2012-05-24 08:39:20.000000000 -0400
@@ -17,6 +17,9 @@
 BuildRequires:  perl(threads)
 BuildRequires:  perl(Thread::Semaphore)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Conflicts:      perl(B:Hooks::OP::Check) < 0.19
+
+%{?perl_default_filter}

 %description
 This module works around two historical bugs in Perl's handling of the %^H
@@ -46,7 +49,7 @@
 ./Build test

 %files
-%doc Changes META.json README
+%doc Changes
 %{perl_vendorarch}/auto/*
 %{perl_vendorarch}/Lexical*
 %{_mandir}/man3/*


> TODO: Do no package useless META.json (installation instructions) and README 
> > (copy of POD).
-%doc Changes META.json README
+%doc Changes
Ok.

> TODO: Declare conflict with `perl(B::Hooks::OP::Check) < 0.19' (Build.PL:96,
> Changes:45).
+Conflicts:      perl(B:Hooks::OP::Check) < 0.19
Ok.

> FIX: Filter private libraries from Provides by calling
> `%{?perl_default_filter}' before %description section.
$ rpmlint perl-Lexical-SealRequireHints.spec
../SRPMS/perl-Lexical-SealRequireHints-0.007-1.fc18.src.rpm
../RPMS/x86_64/perl-Lexical-SealRequireHints-*
perl-Lexical-SealRequireHints-debuginfo.x86_64: E: description-line-too-long C
This package provides debug information for package
perl-Lexical-SealRequireHints.
3 packages and 1 specfiles checked; 1 errors, 0 warnings.
Ok.

> FIX: Do not export private library `SealRequireHints.so()(64bit)'.
$ rpm -q --provides -p
../RPMS/x86_64/perl-Lexical-SealRequireHints-0.007-1.fc18.x86_64.rpm |sort
|uniq -c
      1 perl(Lexical::SealRequireHints) = 0.007
      1 perl-Lexical-SealRequireHints = 0.007-1.fc18
      1 perl-Lexical-SealRequireHints(x86-64) = 0.007-1.fc18
Binary provides are Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to