https://bugzilla.redhat.com/show_bug.cgi?id=826016

--- Comment #2 from Rex Dieter <[email protected]> ---
naming: ok

sources: ok
$ md5sum *.xz
db4aa40110903973b8a37bea6b13a974  nepomuk-core-4.8.80.tar.xz

1. License: NOT ok
looks like some sources have the standard kde blurb, so we'll likely need to
use:

# KDE e.V. may determine that future GPL versions are accepted
License: GPLv2 or GPLv3

here

2.  fix
Requires: kdelibs%{?_isa} >= %{version}
to be:
Requires: kdelibs4%{?_isa} >= %{_kde4_version}
instead.


3.  for the shlibs, probably ought to make a -libs subpkg, with scriptlets
(currently missing);
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig


4. add desktop-file-validate

%check
desktop-file-validate
%{buildroot}%{_kde4_datadir}/applications/kde4/nepomukbackup.desktop


Fix those, and we should be good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to