https://bugzilla.redhat.com/show_bug.cgi?id=829644
David Tardon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from David Tardon <[email protected]> --- (In reply to comment #2) > libmspub.x86_64: E: incorrect-fsf-address > /usr/share/doc/libmspub-0.0.0/COPYING.LGPL > > ^^^ Not a blocker but I advise you to inform upstream about that. I did that already. > * Since you clearly don't have any intentions to package it for really > outdated systems like EL4 you may consider dropping defattr(...) attribute > from %files sections 0 it's not required since rpm 4.4. afaik. It seems rpmlint does not protest about it anymore, so I will do that. > > * The package's so-objects have really strange naming schemes. Hopefully > this is handled by pkg-config so I wouldnt bother. But I noticed (by looking > at the contents of *.pc file) that this package has strict versioned > dependencies on several libraries - "Requires: libwpd-0.9 libwpd-stream-0.9 > libwpg-0.2". Please don't forget about that - some of these libraries could > increase/change their numbering scheme in the future which in turn might (or > might not) break building against this one. Well, all these libs are maintained by the same person upstream, so this should not be a problem. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
