https://bugzilla.redhat.com/show_bug.cgi?id=819953

--- Comment #10 from Gregor Tätzner <[email protected]> ---
(In reply to comment #9)
> I appreciate the feedback, but please focus on review-blockers only first.
Just record the fixes in changelog, so I can track your modifications.

> - macros: please use consistently the name macro
> how so exactly?
The use of the %name macro is pretty much randomly. just search for "lightdm"

i.e. Source0: https://launchpad.net/lightdm/1.2/%{version}/+download/lightdm-%
{version}.tar.gz
Source2: , Patch2: , ...

You should decide if you want to use this macros or not. However, guideline
doesn't state usage of name macro explicitly, so post-review too, I guess.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to