https://bugzilla.redhat.com/show_bug.cgi?id=790805
--- Comment #9 from Adrien Devresse <[email protected]> --- Updated again from the comments Spec URL: http://firwen.org/home/specs/lcg-util.spec SRPM URL: http://firwen.org/home/specs/lcg-util-1.12.0-5.2012061214snap.el5.centos.src.rpm Description: The LCG Utilities package is the main end user command line tool for data management provided by LCG. > - svn export comment refers to trunk. i understand you're doing a snapshot > from trunk, but this should disappear and be replaced with a tag when you're > done. The SVN export comment is just a link to the official source respository, the official sources are provided by a static tarball. I am part of the upstream, a tag will be done as soon as the review is finished in order to integrate the review's modification directly to the trunk. > - requires on libs should be %{version}-%{release}, probably everywhere, more > inline Done > - doc file not marked as doc in libs/devel/python/main, also see inline All files under a %{_docdir}/ macro as tagger like "%doc" by default. > - you have the release notes in the devel package, shouldn't it go to libs so > that it is installed with all packages? Done > The relevant one is the shared-lib-calls-exit. Any chance of this being > patched? Impossible to patch in the current state without big modifications. > Why not: > %doc VERSION LICENSE README > instead of: > %{_docdir}/%{name}-%{version}/VERSION > ... Because my "make install" already install all the documentations in the proper place, and %{_docdir}/ already marks these files like "doc". > I see ppc listed in, but you should add additional information, and then add > > a bugzilla entry, as described in: > http://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support Done, Ticket will be added after review, like specified in the process spec. > Nothing owns %{_docdir}/%{name}-%{version}. Fixed. > Please add the missing %{release}. You probably want to do the same on all > the -libs dependencies. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
