Hi Daniel,
I know that code only too well.
There is a pull request already to replace it, but just removing it is not
going to work for everyone because it breaks some of the more dynamic features
of the administration GUI.
The more general solution needs to be better input validation I guess.
pfsetvlan itself is a beast that we try to deprecate as much as possible
because it makes debugging harder than necessary and is a memory hog.
Thank you for your contribution.
Regards,
--
Louis Munro
[email protected] :: www.inverse.ca
+1.514.447.4918 x125 :: +1 (866) 353-6153 x125
Inverse inc. :: Leaders behind SOGo (www.sogo.nu) and PacketFence
(www.packetfence.org)
On May 1, 2015, at 14:57 , Muller, Daniel (HEALTH)
<[email protected]> wrote:
> [root@pkfn pf]# diff ./lib/pf/SwitchFactory.pm ./lib/pf/SwitchFactory.pm-dist
> 29,30d28
> < use pf::Switch::Cisco::Catalyst_3560;
> < use pf::Switch::HP::Procurve_2600;
> 127,135c125,126
> < # 20150501 - Does not work for us ... -dvm
> < # if ( !(eval "$type->require()" ) ) {
> < # $logger->error("Can not load perl module for switch
> $requestedSwitch, type: $type. "
> < # . "Either the type is unknown or the perl module has
> compilation errors. "
> < # . "Read the following message for details: $@");
> < # return 0;
> < # }
> < $type->require() or
> < $logger->error("Can not load perl module for switch
> $requestedSwitch, type: $type. "
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
PacketFence-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/packetfence-users
