On Tue, May 27, 2008 at 2:26 PM, Aaron Griffin <[EMAIL PROTECTED]> wrote: > On Tue, May 27, 2008 at 2:22 PM, Sebastian Nowicki <[EMAIL PROTECTED]> wrote: >> On BSD systems using a dot as a separator is not allowed. On Mac OSX it >> is deprecated. A colon should be used instead. BSD systems also use the >> "wheel" group instead of "root" to indicate the "super user" group. Both >> groups use the id of 0. >> >> Signed-off-by: Sebastian Nowicki <[EMAIL PROTECTED]> > > I want to do this because Dan always does! > > Acked-by: Aaron Griffin <[EMAIL PROTECTED]>
Lol. We actually do patch review around here? My only suggestion would be removal of the worthless comment and replacing it by something better such as "change perms to root & root user group on all systems" or something, as the current comment is nothing more than a restatement than the code below it. With that said: Acked-by: Dan McGee <[EMAIL PROTECTED]> Now Xavier just needs to signoff and pull this in his tree and we'll have a really well reviewed patch. -Dan _______________________________________________ pacman-dev mailing list [email protected] http://archlinux.org/mailman/listinfo/pacman-dev
