Re: [pacman-dev] [PATCH] makepkg: separate build and install functions in PKGBUILD

[Allan McRae]

Allan McRae wrote:
This patch allows us to split the building and packaging stages of
a PKGBUILD and minimize fakeroot usage. This can be done with less
code duplication (run_build and run_package look quite familiar) but
the run_package function will be where the package splitting logic
is implemented
  


One more thing:

 
@@ -1550,11 +1593,20 @@ else
                if [ "$REPKG" = "0" ]; then
                        devel_update
                        run_build
+                       if [ "$(type -t package)" == "function" ]; then
+                               run_package
+                       fi
                        tidy_install
                fi
 
 		create_package
        else
+               if [ "$(type -t package)" == "function" ]; then
+                       devel_update
+                       run_build
+                       cd "$startdir"
+               fi
+
                msg "$(gettext "Entering fakeroot environment...")"
 
 		if [ "$newpkgver" != "" ]; then
  

I do not like changing back to $startdir as it mean we need to change 
directory to (e.g.) $srcdir/$pkgname-$pkgver in both the build and 
package functions.  I can not see an easy way around this.

Allan


_______________________________________________
pacman-dev mailing list
pacman-dev@archlinux.org
http://archlinux.org/mailman/listinfo/pacman-dev