Dan McGee wrote:
On Thu, Jan 1, 2009 at 10:37 PM, Allan McRae <[email protected]> wrote:
The use if "! -z" to check if a string is not null is not good practice
so replace with the "-n" option. Also use the AND comparison within one
test rather than on two separate tests.
Signed-off-by: Allan McRae <[email protected]>
Looks good to me, maint- worthy?
I'm not worried on this one really. It is not an actual problem, just a
potential one so up to you.
I really need to jump on making this darnded release, don't I..
We really need to get a fix for that whole umask issue first (now we
have figured out the cause).
Allan
_______________________________________________
pacman-dev mailing list
[email protected]
http://archlinux.org/mailman/listinfo/pacman-dev
