On Tue, May 19, 2009 at 4:39 PM, Xavier <[email protected]> wrote: > There is apparently no need to handle the re-compression manually when > applying a xdelta patch in case of bzip2 or xz. > > Only gzip needs to be handled specifically for disabling timestamp with > the -n option. > > After this patch, if xdelta is enhanced with xz support (1-line patch), > it will be transparent from pacman side. > > Signed-off-by: Xavier Chantry <[email protected]> > --- > lib/libalpm/sync.c | 11 ++++------- > 1 files changed, 4 insertions(+), 7 deletions(-) > > > Note that this patch is completely untested :P > >
I tested it now and it works fine. Though I just tested these cases : 1) gz packages 2) xz packages with patched xdelta But all the others cases should be like 2) so it's fine, I checked this by playing directly with xdelta. About xz packages and unpatched xdelta, I tested on 100 packages and the delta were always bigger than 80% of the package size, so bigger than the max delta ratio we defined (70%), so pacman will never use them anyway. _______________________________________________ pacman-dev mailing list [email protected] http://www.archlinux.org/mailman/listinfo/pacman-dev
