On Fri, 10 Jul 2009 00:46:52 +1000 Allan McRae <[email protected]> wrote:
> Dieter Plaetinck wrote: > > On Fri, 10 Jul 2009 00:32:43 +1000 > > Allan McRae <[email protected]> wrote: > > > > > >> Signed-off-by: Allan McRae <[email protected]> > >> --- > >> doc/PKGBUILD-example.txt | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/doc/PKGBUILD-example.txt b/doc/PKGBUILD-example.txt > >> index 0477cb1..7245228 100644 > >> --- a/doc/PKGBUILD-example.txt > >> +++ b/doc/PKGBUILD-example.txt > >> @@ -4,7 +4,7 @@ pkgname=patch > >> pkgver=2.5.4 > >> pkgrel=3 > >> pkgdesc="A utility to apply patch files to original sources" > >> -arch=(i686 x86_64) > >> +arch=('i686' 'x86_64') > >> url="http://www.gnu.org/software/patch/patch.html"; > >> license=('GPL') > >> groups=('base-devel') > >> > > > > Hi, > > why is this better? > > > > Dieter > > It is alway good practice to quote strings in bash. It is also weird > that the arch array was the only non-quoted array. > > Allan I guess it is more a style thing then anything functional. Personally I tend to drive "kiss" to the extreme and avoid quotes if they can be dropped but this is a matter of personal taste, so carry on ;-) Dieter _______________________________________________ pacman-dev mailing list [email protected] http://www.archlinux.org/mailman/listinfo/pacman-dev
