On Sun, Oct 18, 2009 at 5:38 PM, Dan McGee <[email protected]> wrote:
> On Sat, Oct 17, 2009 at 11:40 PM, Laszlo Papp <[email protected]> wrote: > > * Size examined str* function usage is a common coding practice, > > * because it's more safer to avoid breakage while using str* > functions. > > > > Signed-off-by: Laszlo Papp <[email protected]> > > --- > > @@ -189,7 +189,7 @@ char *mdirname(const char *path) > > } > > /* no slash found */ > > free(ret); > > - return(strdup(".")); > > + return(strndup(".", PATH_MAX)); > > } > > > > Um...what? Really? > > -Dan > > It doesn't cause problem, but if you change "." for a variable it will be more reasonable. But I can remove such lines from the patch, if otherwise it's okay. Thanks the feedback. Best Regards, Laszlo Papp
