On 03/06/10 20:10, Andres P wrote:
On 6/3/10, Allan McRae<[email protected]>  wrote:

Looks good.   Pushed to my post-3.4 branch.

Allan



$ time for i in {1..1000}; do bsdtar -tf
/var/cache/pacman/pkg/kernel26-2.6.33.4-1-i686.pkg.tar.xz -q \*
/dev/null; done
real    0m18.170s
user    0m14.196s
sys     0m3.130s

$ time for i in {1..1000}; do file -bizL
/var/cache/pacman/pkg/kernel26-2.6.33.4-1-i686.pkg.tar.xz>/dev/null;
done
real    0m23.273s
user    0m7.603s
sys     0m9.956s


So,

Is the only reason the 'case in file -bizL' block is still there is because no
one has written a patch for it?

Because now you've got your performance sorted out.


No... we would still need "file -bizL" to identify the non-tar compressed files and extract them. Given these are about the same speed (time difference is a much smaller percentage on my machine), we need to guess which is more regularly used as a source; compressed non-tar files or files bsdtar can extract that do not currently get extracted.

So I see any further change giving little gain.

Allan

Reply via email to