On 21/06/10 06:00, Jeff wrote:
On Sat, Jun 19, 2010 at 02:41:02PM +1000, Allan McRae wrote:
This is a feature that is acceptable. But I do not like using an
option=() value to decide whether to run it. I would prefer a "--check"
option to be added. Then people can choose to run the check function
or not without requiring to edit the PKGBUILD. If they always want
check() to be run, an alias for makepkg can be used.
Actually, I never envisioned this to be used in the PKGBUILDs other than
for a very few critical packages (toolchain) where it doesn't make sense
to not test. IMO, this would better be suited as an edited value in
makepkg.conf per the builders's desire the same as whether he wants the
doc directory wiped. The use of an alias in this case would serve
nothing more than to override a global directive, which ISTM is what
~/.makepkg.conf is for.
I do not see the option as being the same as removing docs. All the
values in OPTIONS affect the files in the final package. The "check"
option would not.
If check() is designed to be only used in cases where it is important to
always run the test suite, then I suggest we make running check() to be
the default and that it can only be disabled with a --nocheck command
line flag.
Allan
