On Wed, Oct 6, 2010 at 6:38 AM, Nezmer <[email protected]> wrote: > On Tue, Oct 05, 2010 at 07:56:53PM -0500, Dan McGee wrote: >> On Tue, Oct 5, 2010 at 6:03 PM, Dan McGee <[email protected]> wrote: >> > Hey, >> > >> > I noticed you did some merges and updates on your pacman-bsd branch >> > today (http://gitorious.org/pacman-bsd/pacman-bsd). Have you thought >> > about trying to get some of this work into the main branch of code so >> > you don't have to maintain as much? I know we've already taken in a >> > few things, like the makepkg colors checking stuff, but it might be >> > nice to ensure we are as portable as possible out of the box. >> > >> > I CC-ed in Allan because a lot of these are touchups to makepkg. I >> > know we may not seem to move quickly at times, but we do appreciate >> > patches and contributions from others. >> >> My quick review of the differences picked out these things as stuff >> that should/could be looked at to improve compatibility and >> correctness: >> >> 1. DBPath/CacheDir parsing in scripts/ and contrib/ >> 2. Fix bash regexes: =~ should never have RHS quotes >> 3. Hardcoded '.tar.gz' in some contrib/ scripts >> 4. contrib/, use configurable etc/ directory (sysconfdir I believe) >> 5. bsdtar binary location, don't assume it is on path? >> 6. Use of seq (not a bash builtin) >> 7. makepkg: strip binary location hardcoded, perhaps use $STRIP >> 8. makepkg: mknod vs. mkfifo >> 9. bash shebang in scripts >> >> -Dan > > Just saw this. A very good summary. > > I'm welling to answer any questions or put together any patch you are > interested to take.
I'd basically say anything that is in the above list is fair game for patches. #2 and #3 are pretty low-hanging, non-invasive stuff if you'd like somewhere to start. I think I just handled #6 as we only used it in one contrib script; patch going to the ML. This message is also going to the ML so we can maybe get some discussion going there. -Dan
