On Tue, Jan 18, 2011 at 1:01 PM, Dan McGee <[email protected]> wrote: > On Sun, Jan 16, 2011 at 6:38 AM, Allan McRae <[email protected]> wrote: >> When installing packages from a file, the integrity check count >> stays at (0/x) complete. This ensures it is bumped to (x/x) at >> the end of the process. >> >> Signed-off-by: Allan McRae <[email protected]> >> --- >> >> I'm not sure this is the best way to fix this issue... But given the >> loop is essentially doing nothing in this case, I do not see the point >> in updating the progress bar as we go. > For now this seems fine... it would make more sense if we allowed > something like `pacman -S mypackage foobar pkg-file-xxx.pkg.tar.gz`.
And on that note, I've taken this patch but also "added" current++ calls in the two other early "continue" loop exits- by instead making the counter the responsibility of the for loop. Revised patch on the way. -Dan
