On 01.06.2011 20:33, Dan McGee wrote:
> On Fri, May 27, 2011 at 7:04 AM, Xavier <[email protected]> wrote:
>> Florian Pritz wrote:
>>>
>>> I've asked a few people, looked at the code used for stripping and I
>>> think it's safe to check only executable files. That cut down the time
>>> needed for sage from 5 min to 19 sec (i7-920, tempfs).
>>>
>>> I've also noticed that the stripping code uses -perm -o+x  and not
>>> -executable. The manpage says -executable also checks ACLs and owner,
>>> group, other. Any reason why we don't use -executable?
>>>
>>
>> If it's not portable, we need a specific case for GNU/Linux.
>> But we already have to do that for other tools.
> If you can find it in the manpages for our current known-working
> platforms (FreeBSD, OS X, Cygwin?), then I'm fine with switching to
> it. Otherwise as Xavier said it might not be worth the hassle.
> 

Ok, I'll just use u+x and not waste our time.

I also noticed the strip code actually uses u+w so this shouldn't be
changed anyway (.a files are 644 only).

-- 
Florian Pritz -- {flo,bluewind}@server-speed.net

Attachment: signature.asc
Description: OpenPGP digital signature



Reply via email to