On Thu, Jun 23, 2011 at 9:11 PM, Dan McGee <[email protected]> wrote: > On Thu, Jun 23, 2011 at 6:19 AM, Allan McRae <[email protected]> wrote: >> On 23/06/11 02:13, Dan McGee wrote: >>> >>> On Wed, Jun 22, 2011 at 3:54 AM, Allan McRae<[email protected]> wrote: >>>> >>>> There was a lot of inconsistency in how strings that should not be >>>> translated (program names, option flags, PKGBUILD directives, etc) were >>>> handled. This patch moves them all outside the gettext invocation for >>>> consistency and to prevent accidental translation. >>>> >>>> Note that some of these may need reverted if they cause difficulties in >>>> translation due to gettext usage in bash not taking positional parameters >>>> for arguments. A quick survey of current translations idicates that this >>> >>> "indicates" >>>> >>>> issue will be rare. Also, we should be able to catch these before a full >>>> string freeze given we are going to probably need a "developer preview" >>>> release before the next release series. >>> >>> This seems reasonable. Gettext pisses me off a lot here that it can't >>> support these, almost tempted to say we could write a wrapper function >>> but that seems overkill. >>> >>> Do you want to do the message catalog split to possibly make catching >>> these errors easier? >>> >> >> You mean splitting makepkg (and the rest of the bash scripts) into their own >> translation unit? It is on my TODO list, but I have not quite figured out >> how to do that yet... > > It shouldn't be that hard. I'll give it a shot here real quick...
"real quick" turned out to be a bit more work to make things readable and logical, but here we go: http://code.toofishes.net/cgit/dan/pacman.git/log/?h=po-split Let me know what you think about merging this. -Dan
