Hallo, Dan McGee: > > > >> > + echo "$(gettext "NOT FOUND")" >&2 > >> > + errors=1 > >> > + found=0 > >> > + fi > >> > + > >> > + if (( found )); then > >> > + if ! gpg --quiet --batch --verify "$file" 2> > >> > /dev/null; then > >> > + echo "$(gettext "Verification failed")" > >> > >&2 > >> Any need to eat stderr? If things only show up in exceptional cases, > >> I'd rather it come through. > > > > Oh, that's supposed to be a 1. > I was suggesting no redirection at all.
That redirect is taken from pacman-key (the patch introducing it is http://mailman.archlinux.org/pipermail/pacman-dev/2010-October/011724.html). Maybe Denis (if he's still reading this list) can elaborate on why it's there. > > >> This check should probably match how we do it elsewhere; e.g., > >> check_signature() the first two lines. > > > > Hm, check_signature()? Either grep is lying to me or that doesn't exist > > anywhere. > > > >> I'd move it inside check_pgpsigs itself. Also declare it upfront where > >> we set the rest of these. > > create_signature, whoops! Will do. -- Wieland
pgptlLQY1MeV7.pgp
Description: PGP signature
