On Thu, Jul 21, 2011 at 1:39 PM, Benedikt Morbach
<[email protected]> wrote:
> Hi,
>
> I've send this before, but it seems like it didn't reach the list.
> I apologize if I'm flooding your inbox and you got this patch series twice.
>
> The pacman codebase is completely new to me, so please forgive me the
> obvious mistakes that I overlooked and feel free to point them out and yell 
> at me.
>
> This implements most features from 
> https://wiki.archlinux.org/index.php/User:Allan/Pacman_OptDepends
>
> It probably isn't quite ready to be merged yet, but I want to gather some
> feedback on the stuff I've already done.
I tried to comment on most of the patches (1-4). The overall work
looks really good, just a few minor comments in there.

When you resubmit, can you be sure to include signoffs on each patch?
man git-commit, -s option.

-Dan

Reply via email to