On Thu, Aug 18, 2011 at 2:42 AM, Lukas Fleischer <[email protected]> wrote: > Return with ALPM_ERR_WRONG_ARGS instead of causing a potential segfault > if alpm_fetch_pkgurl() is invoked with a NULL URL. > > Signed-off-by: Lukas Fleischer <[email protected]> > --- Thanks.
> lib/libalpm/dload.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c > index a1b6364..0e1c64b 100644 > --- a/lib/libalpm/dload.c > +++ b/lib/libalpm/dload.c > @@ -450,6 +450,7 @@ char SYMEXPORT *alpm_fetch_pkgurl(alpm_handle_t *handle, > const char *url) > int ret; > > CHECK_HANDLE(handle, return NULL); > + ASSERT(url, RET_ERR(handle, ALPM_ERR_WRONG_ARGS, NULL)); > > /* find a valid cache dir to download to */ > cachedir = _alpm_filecache_setup(handle); > -- > 1.7.6 > > >
