On 13/12/12 21:38, Olivier Brunel wrote: > Instead of always logging "synchronizing package databases" we only log when > (and which) db was synchronized.
This gains us very little because we do not know if a database was not updated due to being up-to-date or due to a failure. So if this is to be included, I think it would need logging for all situations. > Signed-off-by: Olivier Brunel <[email protected]> > --- > src/pacman/sync.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/pacman/sync.c b/src/pacman/sync.c > index 938f9d6..6c8923d 100644 > --- a/src/pacman/sync.c > +++ b/src/pacman/sync.c > @@ -338,6 +338,8 @@ static int sync_synctree(int level, alpm_list_t *syncs) > success++; > } else { > success++; > + alpm_logaction(config->handle, _("synchronized database > %s\n"), > + alpm_db_get_name(db)); > } > } > > @@ -954,7 +956,6 @@ int pacman_sync(alpm_list_t *targets) > if(config->op_s_sync) { > /* grab a fresh package list */ > printf(_(":: Synchronizing package databases...\n")); > - alpm_logaction(config->handle, _("synchronizing package > lists\n")); > if(!sync_synctree(config->op_s_sync, sync_dbs)) { > return 1; > } >
