On Wed, Jan 30, 2013 at 7:40 AM, Dave Reisner <[email protected]> wrote: > On Wed, Jan 30, 2013 at 10:33:52PM +1000, Allan McRae wrote: >> On 30/01/13 12:23, Andrew Gregory wrote: >> > No other contrib script is executable. >> > >> > Signed-off-by: Andrew Gregory <[email protected]> >> > --- >> >> Ack. >> >> > The scripts in test/scripts are also inconsistent, but I'm not sure whether >> > they should be executable or not. >> >> Dave? >> > > I don't see any harm in making scripts in test/scripts executable. > They're meant to be run, unlike the .sh.in files in contrib/ or > scripts/.
Agreed- the ones that are executable actually have __main__ methods (if Python) or are standalone bash scripts that don't need preprocessing. -Dan
