On 04/03/13 20:03, Sébastien Luttringer wrote: > On Mon, Mar 4, 2013 at 8:39 AM, Allan McRae <[email protected]> wrote: >> On 04/03/13 12:01, Sébastien Luttringer wrote: >>> This option (enabled by default) removes static library files in packages. >>> >>> Related to the thread: >>> https://mailman.archlinux.org/pipermail/arch-dev-public/2013-March/024552.html >>> >>> Signed-off-by: Sébastien Luttringer <[email protected]> >>> --- >> >> You think given I was the one who suggested to use PURGE_TARGETS for >> this, that you might of thought have thought twice about doing this >> being the way to implement it... > I thought you suggest PURGE_TARGETS as a way to find a quick solution, > saving you time to add a new option. > >> So provide an explanation why this is better. libtool option is not an >> answer because we could merge that into PURGE too... > Having all the unwanted stuff removed in the purge option, avoid > duplication of the same code and make removal of future others files a > regex addition. > Merge libtool into purge was my alternative patch option but looking > at the number of PKGBUILD using the option, I thougth it was a lighter > path to keep it and provide it counterpart for *.a files to stay > coherent. > .$ grep -lri '!libtool' /var/abs|wc -l > 1354 > As libtool is not an answer, this patch is in the bad way. >
The correct answer is that this will need frequently disabled. So purge is really not a solution. I just wanted to see what the though process was here... I will provide a proper review of your patch now. Allan
