On Sun, Mar 10, 2013 at 09:08:28AM +1000, Allan McRae wrote: > On 10/03/13 08:56, William Giokas wrote: > > On Sat, Feb 23, 2013 at 01:08:44PM +0100, Olivier Brunel wrote: > >> Because --noextract also implies to not download/verify source files, it > >> wasn't > >> possible to simply do that, without either extracting and/or building. > >> (Note: --verifysource takes precedence over --noextract) > >> > >> Signed-off-by: Olivier Brunel <[email protected]> > >> --- > >> doc/makepkg.8.txt | 5 +++++ > >> scripts/makepkg.sh.in | 8 ++++++-- > >> 2 files changed, 11 insertions(+), 2 deletions(-) > >> > > <SNIP> > >> > >> -if (( NOEXTRACT )); then > >> +if (( NOEXTRACT && ! VERIFYSOURCE )); then > >> warning "$(gettext "Using existing %s tree")" "src/" > >> elif (( REPKG )); then > >> if (( ! PKGFUNC && ! SPLITPKG )) \ > >> @@ -2897,6 +2900,7 @@ elif (( REPKG )); then > >> else > >> download_sources > >> check_source_integrity > >> + (( VERIFYSOURCE )) && exit 0 # $E_OK > > Right here. I know that it might still be useful to download VCS > > packages for some odd reason, but I think this should look more like > > > > else > > if (( VERIFYSOURCE )); then > > download_sources fast > > else > > download_sources > > fi > > (( VERIFYSOURCE )) && exit 0 # $E_OK > > > > This would skip the vcs sources, which shouldn't have checksums to > > verify at all. > > That removes the ability to easily download sources for future offline > builds, which was the only reason I accepted this... > But for that we have -o...
-- William Giokas | KaiSforza GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF
pgpfHsuBsGCUA.pgp
Description: PGP signature
