On Wed, Mar 13, 2013 at 11:37:10PM -0700, Connor Behan wrote: > Calling pacman -Sp and pacman -Sup are guaranteed not to install a > package.
I feel the need to point out that --ignore guarantees that a package won't even be *downloaded*. Xyne already mentioned it, but I'll parrot his concern about this effectively changing command line API. > So the user's IgnorePkg pref is respected regardless of whether > or not we print the mirror location. Therefore we do so in the case of > -Sp as this gives the full information requested by the user. We avoid > doing so in the case of -Sup as this would mislead the user into > thinking that the upgrade is bigger than it really is. This fixes an > edge case with devtools. > > Signed-off-by: Connor Behan <[email protected]> > --- > src/pacman/conf.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/pacman/conf.c b/src/pacman/conf.c > index 3f1b1c3..99e6af1 100644 > --- a/src/pacman/conf.c > +++ b/src/pacman/conf.c > @@ -1010,6 +1010,13 @@ int parseconfig(const char *file) > if((ret = _parseconfig(file, §ion, 1, 0))) { > return ret; > } > + > + /* #FS#34066 - Querying URLs for packages specified on the command line > (even ignored ones) should succeed */ > + if(config->print && !config->op_s_upgrade) { > + config->ignorepkg = NULL; > + config->ignoregrp = NULL; > + } > + > if((ret = setup_libalpm())) { > return ret; > } > -- > 1.8.1.5 > >
