On Fri, Apr 05, 2013 at 09:09:07PM -0400, Dave Reisner wrote: > On Fri, Apr 5, 2013 at 8:42 PM, Sébastien Luttringer <[email protected]>wrote: > > > On Sat, Apr 6, 2013 at 2:32 AM, Dave Reisner <[email protected]> wrote: > > > > > On Sat, Apr 06, 2013 at 02:27:30AM +0200, Sébastien Luttringer wrote: > > > > Avoid makepkg to let src/ directory after updating the sums > > > > > > This has potential to incur unintended/unwanted side effects... I don't > > > think this should be the default. You could potentially look at > > > $BUILDDIR/src beforehand and only pass -c if the dir doesn't exist > > > beforehand, but I'm not sure we want to play that game. > > > > > > > I don't see what kind of unintented/unwanted side effects this can occur. > > Unless you speak about --asroot. > > Is the following code could avoid us of those effects ? > > > > export BUILDDIR=$(mktemp --directory -t updpkgsums.XXXXX) > > makepkg --clean > > > > > Sorry for not being clear. My gripe is with the --clean flag. I'm strongly > disagree with the idea that we should assume the user doesn't want their > possibly large and already compiled build directory wiped out.
Had this come up earlier, I may have said, "Hmm. Well, the vcs sources extract on a download, so this could help", but they don't do that anymore, so there's really no need for this at all, and as Dave said, it could be unnecessarily destructive. Thanks -- William Giokas | KaiSforza GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF
pgp3uZ6YTncLW.pgp
Description: PGP signature
