On Sat, Apr 6, 2013 at 11:39 AM, Florian Pritz <[email protected]> wrote:
> On 06.04.2013 02:18, Sébastien Luttringer wrote: > > Add --asroot into the makepkg call to allow package upgrade when running > as root. > > Now why would you want to do that? > To be able to update checksum in a chroot and in a building vm. Also because the script fail in an ugly manner, asking to add --asroot with no way to do it. > > NACK unless you have a very good reason and make that an option rather > than a default. > Ya and Allan point that it break when you're non-root... really bad patch :/ I see 4 options: 1) Forbid to be run as root with a dedicated message. I think we should let the user do what they want. There is really few cases where a makepkg -g can broke thing ran as root. 2) Automatically add the option --asroot when user is root This allow to update checksum in all case. 3) Update makepkg --asroot to work don't bother us if we are not root. 4) Add getopt to updpkgsums, to handle a new --asroot option. If we can avoid this and keep the script simple... Two, seems to me the better one. What do you think? -- Sébastien "Seblu" Luttringer https://www.seblu.net GPG: 0x2072D77A
