Re: [pacman-dev] [PATCH] Add prepare function to PKGBUILD proto files

[William Giokas]

On Tue, Apr 23, 2013 at 02:14:29AM -0400, Eric Bélanger wrote:
> Signed-off-by: Eric Bélanger <snowmanisc...@gmail.com>
> ---
>  proto/PKGBUILD-split.proto | 7 ++++++-
>  proto/PKGBUILD.proto       | 7 ++++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/proto/PKGBUILD-split.proto b/proto/PKGBUILD-split.proto
> index 42c469c..f2a2d11 100644
> --- a/proto/PKGBUILD-split.proto
> +++ b/proto/PKGBUILD-split.proto
> @@ -24,10 +24,15 @@ backup=()
>  options=()
>  install=
>  changelog=
> -source=($pkgbase-$pkgver.tar.gz)
> +source=($pkgbase-$pkgver.tar.gz $pkgname-$pkgver.patch)

Just nit-picking, but I personally prefer these arrays to be split on
different lines, i.e.:

source=($pkgbase-$pkgver.tar.gz
        $pkgname-$pkgver.patch)

>  noextract=()
>  md5sums=() #generate with 'makepkg -g'
>  
> +prepare() {
> +     cd "$srcdir/$pkgname-$pkgver"
> +     patch -p1 -i "$srcdir/$pkgname-$pkgver.patch"
> +}
> +
>  build() {
>       cd "$srcdir/$pkgbase-$pkgver"
>       ./configure --prefix=/usr
> diff --git a/proto/PKGBUILD.proto b/proto/PKGBUILD.proto
> index 8e9ae04..e78b110 100644
> --- a/proto/PKGBUILD.proto
> +++ b/proto/PKGBUILD.proto
> @@ -24,10 +24,15 @@ backup=()
>  options=()
>  install=
>  changelog=
> -source=($pkgname-$pkgver.tar.gz)
> +source=($pkgname-$pkgver.tar.gz $pkgname-$pkgver.patch)
>  noextract=()
>  md5sums=() #generate with 'makepkg -g'
>  
> +prepare() {
> +     cd "$srcdir/$pkgname-$pkgver"
> +     patch -p1 -i "$srcdir/$pkgname-$pkgver.patch"
> +}
> +
>  build() {
>       cd "$srcdir/$pkgname-$pkgver"
>       ./configure --prefix=/usr
> -- 
> 1.8.2.1
> 
> 

-- 
William Giokas | KaiSforza
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF

pgpkr6NI6J7jd.pgp
Description: PGP signature