On 28/05/13 17:43, Xavion wrote: > I've discovered that the patch I submitted earlier today fails if the > string or list is empty. I've modified the code to prevent this, but will > wait until those other patches you mentioned are merged before resubmitting > mine. > > The other thing I've been thinking is that perhaps it's better to use the > yellow text for the "Replaces" array. This is kind of like a warning, > while having the "Conflicts With" array in red symbolises something > stronger (i.e. like an error). > > If the "Description" is coloured yellow in the information output, it > probably should look the same in the search output as well. I'm thinking > you guys might not want to go down that path, which strengthens the case > for using yellow in "Replaces" instead. >
The search output is already too much of a rainbow. So I agree with using yellow for replaces and red for conflicts. I'd suggest splitting your patch into two parts. The first being adding the set-up for adding colours and the second changing the output colours. Allan
