On 26/06/13 22:14, Dan McGee wrote: > On Wed, Jun 26, 2013 at 12:02 AM, Allan McRae <[email protected]> wrote: >> We used to carry a patched version of ltmain in our repos to fix libtools >> issues with -Wl,-as-needed. Now that ltmain is "generated" by autoreconf, >> we manually patch it afterwards. >> >> Signed-off-by: Allan McRae <[email protected]> >> --- >> autogen.sh | 3 ++- >> build-aux/.gitignore | 3 ++- >> build-aux/ltmain-asneeded.patch | 33 +++++++++++++++++++++++++++++++++ >> 3 files changed, 37 insertions(+), 2 deletions(-) >> create mode 100644 build-aux/ltmain-asneeded.patch > > I'm not super familiar with this, so hopefully this isn't too dumb of > a question to ask. Even though this patch didn't go upstream, we know > for a fact we can't do this some other way that is supported natively > by the tools? >
So... this is an old bug in libtool that has been known since 2006. [1]. Many other patch their ltmain file in a similar fashion [2], but the one here is much better as it handles concatenated LDFLAGS (e.g. -Wl,--as-needed,--sort-common). Not much has happened upstream about this... [3]. I should chase it up. Anyway, it is broken and can not be fixed without patching. This patch is from what we used to carry in git. [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347650 [2] http://maemo.gitorious.org/maemo-af/libcontentaction/blobs/master/ltmain-asneeded.patch [3] http://lists.gnu.org/archive/html/bug-libtool/2009-12/msg00038.html Allan
