On 06/08/13 00:23, Dave Reisner wrote: > On Mon, Aug 05, 2013 at 11:30:09AM +0800, lolilolicon wrote: >> Allan McRae <[email protected]> wrote: >>> On 04/08/13 02:26, Dave Reisner wrote: >>>> + if [[ $1 = ?(_[[:alpha:]])+([[:alnum:]_])?(+)=* ]]; then >>> >>> This matches "1=2" which then bails on the export. Should it be: >>> >>> +(_[[:alpha:]])?([[:alnum:]_])?(+)=* >>> >> >> There must be a typo, I think it should be this: >> >> [_[:alpha]]*([_[:alnum:]])?(+) >> >> which also allows setting the special shell variable $_ but maybe it's fine. >> > > Yeah, this is the correct solution. It's fine if people try to set > things they aren't supposed to -- makepkg shouldn't actively be in the > game of trying to discourage it. >
@Dave: updated patch on its way?
