On 09/10/13 21:36, Lukas Jirkovsky wrote: > On Wed, Oct 9, 2013 at 5:05 AM, Allan McRae <[email protected]> wrote: >> On 09/10/13 12:54, Allan McRae wrote: >>> On 02/10/13 03:23, Lukáš Jirkovský wrote: >>>> Previously, the sources in $srcdir were always removed prior building. >>>> >>>> After this change the sources are only updated. This makes >>>> incremental builds possible. Also this goes in line with the current >>>> behaviour >>>> for other types of sources, where the sources are just being overwritten >>>> without >>>> being removed first. >>>> --- >>> >>> Patch seems to be broken: >>> >>> makepkg: line 586: unexpected EOF while looking for matching ``' >>> makepkg: line 3188: syntax error: unexpected end of file >>> >> >> This is all due to the use of backticks noted below and how they get >> mangled when using m4. > > Oh, right. I tested this on the makepkg that I already had installed > on my system, so I didn't catch this one. I'll take a look at it, > maybe the pushd is not even necessary. > > BTW: should I resubmit this patch immediately after fixing the issue > or should I wait for the "Moved dependencies of download functions > into a library"? >
Good question... Your patch would be easier to merge after the fact. Just submit, I can merge. Allan
