On 24/12/13 01:05, Jeremy Heiner wrote: > This patch is not ready for accepting into the repository. > > It does not work for VPATH builds (because the paths to all the .py > tests are seen as relative to $(builddir)). Dave is working on a fix > for this VPATH issue, so a real version of this patch must wait to > incorporate his commit. This patch works fine for in-$(srcdir) builds. > > The purpose of posting it is to follow up Saturday's conversation. > I think it implements all of Allan's suggestions (if I understood > correctly). The real commit message would be something like: > > SCRIPTLET_SHELL and LDCONFIG can be set via args to configure, and up > 'till now those options were passed to pactest by Makefile.am as > command-line args. That works fine for 'make check', but required > repeated specification when running pactest manually. This patch makes > pactest a configured file so it has direct access to those options and > they no longer need to be specified (by Makefile.am nor by hand). > > Also the default for the pactest '-p' arg is changed to be the pacman > that the make builds. The '-p' arg is still available, but it should > now be very rare to have to use it when calling pactest manually. > --- > Makefile.am | 4 -- > configure.ac | 1 + > test/pacman/.gitignore | 1 + > test/pacman/pactest.py | 125 -------------------------------------------- > test/pacman/pactest.py.in | 128 > ++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 130 insertions(+), 129 deletions(-) > delete mode 100755 test/pacman/pactest.py > create mode 100644 test/pacman/pactest.py.in
Anyone want to point out a git command to allow us to see the differences between the old pactest.py and the new pactest.py.in. Otherwise, I'd need to see this as two patches - one to move the file and the second to make the adjustments. Allan
