On 14-03-02 18:20:34, Allan McRae wrote:
> > -A|--ignorearch) IGNOREARCH=1 ;;
> > -c|--clean) CLEANUP=1 ;;
> > -C|--cleanbuild) CLEANBUILD=1 ;;
> > @@ -2595,7 +2601,7 @@ while true; do
> > -F) INFAKEROOT=1 ;;
> > -g|--geninteg) GENINTEG=1 ;;
> > --holdver) HOLDVER=1 ;;
> > - -i|--install) INSTALL=1 ;;
> > + -i|--install) INSTALL=1; NOARCHIVE=0 ;;
>
> I do not like this. It means that if I specify both --install and
> --noarchive it does something, but that something depends on what order
> I specify them in. Just do INSTALL=1; That the end of this case
> statement, do a check if (( INSTALL && NOARCHIVE )) and do an error.
>
> > --key) shift; GPGKEY=$1 ;;
> > -L|--log) LOGGING=1 ;;
> > -m|--nocolor) USE_COLOR='n' ;;
> >
After a quick overview of how the other options handle this, the check at the
end of the case statement does not seem very consistent with the rest. I suggest
we proceed as for NOBUILD: check the option before all install_package calls.
--
Pierre Neidhardt
Many hands make light work.
-- John Heywood
