On 08/04/14 at 03:43pm, Allan McRae wrote: > On 03/08/14 15:31, Andrew Gregory wrote: > > Original-work-by: Allan McRae <[email protected]> > > Signed-off-by: Andrew Gregory <[email protected]> > > --- > > > > Changes: > > * set alternate root with PACROOT environment variable > > * filter results through grep and sort to remove empty lines and duplicates > > * add parent directories (duplicates filtered out by sort) > > * verify that the resolved directory is inside our root > > * replace longer symlinks first > > * handle conflict between resolved directory and existing filelist entry > > > > This looks fine on first pass to me. Why do you think this is a WIP? > Is there something more needing done? > > A
I think it's substantively ready but my bash and awk are not particularly great and probably in need of some cleanup and the PACROOT variable needs a little work. It at least needs to be documented, and I'm considering making it an option rather than an environment variable and making the default dbpath relative to it. apg
