2014-08-27 21:15 GMT+02:00 Dave Reisner <[email protected]>: > On Wed, Aug 27, 2014 at 08:58:22PM +0200, Maxim Andersson wrote: >> 2014-08-27 17:55 GMT+02:00 Dave Reisner <[email protected]>: >> > On Wed, Aug 27, 2014 at 06:09:37PM +0400, Yanus Poluektovich wrote: >> >> Why is the dir list comma-separated? The standard for *nix is to separate >> >> paths with a colon. >> > >> > In environment variables, sure. Do you have an example of where this is >> > done in a command line argument? >> > >> > I'm actually reconsidering my stance on the feature entirely, as it >> > disallows cachedirs with legitimate "," characters in them. I think >> > maybe it's sufficient to just accept multiple -c arguments (a feature >> > which isn't actually documented anywhere but in the commit message and >> > code). >> >> I feel it would be enough with multiple -c arguments. I added the >> comma-separated option so it would behave similar to the -i argument. > > I understand the rationale, but remember that "," is invalid in a > package name (arguments to -i). Meanwhile, it's entirely valid for a > path (arguments to -c). >
Yes, it's bad if paccache breaks when using a valid (but somewhat strange) path. I've removed the comma-separated option and updated usage() in a new patch. I also aligned the nocolor-option with the other long options in usage() and remove some leading whitespaces in parse_filename(). >> If the comma-separated list is removed, should there be a note about >> the multiple -c option in the usage function? >> > > Should probably be there regardless. > > d >
