On 25/12/14 08:27, Andrew Gregory wrote: > On 12/24/14 at 04:07pm, Allan McRae wrote: >> On 24/12/14 07:53, Andrew Gregory wrote: >>> tap.sh is a reusable TAP library that handles test counting and provides >>> useful diagnostic messages on test failures. >>> >>> Signed-off-by: Andrew Gregory <[email protected]> >>> --- >>> >>> I'm maintaining tap.sh outside of pacman (hence the MIT license) at >>> https://github.com/andrewgregory/tap.sh >>> Documentation is available there. >> >> I did a review of the script and have no comments. >> >>> I have no idea if EXTRA_DIST is the correct place to list tap.sh, but >>> distcheck >>> seems to work with it. >> >> That seems fine. >> >>> Makefile.am | 2 +- >>> test/scripts/human_to_size_test.sh | 39 ++------- >>> test/scripts/parseopts_test.sh | 44 ++-------- >>> test/tap.sh/tap.sh | 163 >>> +++++++++++++++++++++++++++++++++++++ >> >> Do we need the tap.sh/ directory here? > > No. I had initially included the documentation file; unless somebody > wants it added back, the script can be moved up a level. >
Move it up a level and then this patchset is fine to include. Are you working with Florian to get his makepkg-template testsuite using this? Allan
