On 23/02/18 13:54, Allan McRae wrote:
> On 23/02/18 12:38, Morgan Adamiec wrote:
>> I do apologise for the bad patch. I'm not proficient in bash at all. I
>> basically wrote this patch out of frustration after having spent an
>> hour trying to figure out why a package on the AUR would not install
>> and it ended up being this exact problem. I looked through the code
>> and saw sometimes depends are quoted and sometimes they are not.
>> Adding the quotes fixed the problem so that was that.
> It wasn't a bad patch as such...  it was just that there is a better way
> to handle this.
> Do you have a link to the AUR PKGBUILD that failed?   What was the
> output you were getting?

Here is the issue line:
makedepends=('make qt5-tools')

makepkg "handles" this by separating make and qt5-tools.  However
--printsrcinfo generates:

makedepends = make qt5-tools

This confuses tools.

linting this variable (and other depends ones) using the same rules as
pkgname would be the ideal solution.


Reply via email to