Re: [pacman-dev] [PATCH] libmakepkg/integrity: fix regression that broke --install

[Eli Schwartz]

On 03/05/2018 10:36 AM, Eli Schwartz wrote:
> -     local pkgarch pkg_file
> +     local pkg pkgarch pkg_file
>       local pkgname_backup=("${pkgname[@]}")
>       local fullver=$(get_full_version)
>  
>       msg "$(gettext "Signing package(s)...")"
>  
> -     for pkgname in ${pkgname_backup[@]}; do
> -             pkgarch=$(get_pkg_arch $pkgname)
> -             pkg_file="$PKGDEST/${pkgname}-${fullver}-${pkgarch}${PKGEXT}"
> +     for pkg in "${pkgname[@]}"; do
> +             pkgarch=$(get_pkg_arch $pkg)
> +             pkg_file="$PKGDEST/${pkg}-${fullver}-${pkgarch}${PKGEXT}"
>  
>               create_signature "$pkg_file"
>       done
>  
>       # check if debug package needs a signature
>       if ! check_option "debug" "y" || ! check_option "strip" "y"; then
BTW any reason we even need to do all this instead of, say, using
print_all_package_names

We could probably do that both here and in install_package, especially
if/when "makepkg --packagelist: just list the built package files we
will build" is accepted.

See? This patch is even useful for makepkg itself, why would we ever not
want it. :p

-- 
Eli Schwartz
Bug Wrangler and Trusted User

signature.asc
Description: OpenPGP digital signature