On 11/13/18 11:29 PM, Eli Schwartz wrote: > All of our scripts depend on the same pattern .sh.in, and since commit > b5d62d2c91a2caf5c18945921cdf12af6f36b2d4, they also all (not just > makepkg itself) depend on libmakepkg. > > There's no real reason to include separate targets for them just to > establish dependency rules. > > While we are at it, fix a longstanding bug where generated wrapper > scripts did not depend on wrapper.sh.in (which due to moving to .lib, > requires we regenerate the script too), by making the shared target > pattern depend on it. All our generated scripts now require the wrapper, > even repo-add which now uses libmakepkg. > > Signed-off-by: Eli Schwartz <eschwa...@archlinux.org> > --- > > v2: Replace commits 3 and 4 of the previous patchset. The logic was > wrong, and the scripts *do* depend on wrapper.sh.in, since they need to > be regenerated in order to be moved to .lib/ -- the result of failing to > do this was that makepkg now broke the same way the other scripts were > already broken.
Correction again: my patch made this happen, the current state of master is that modifications to wrapper.sh.in simply never propagate to wrapped scripts... -- Eli Schwartz Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
