On Sat, 16 Jan 2021 at 07:23, Andrew Gregory <[email protected]> wrote: > > Download-related config options are currently limited to builds with > curl. This causes compilation errors when those options are used > without an appropriate guard which often goes unnoticed because we all > use curl. Front-ends providing their own download callback may also > want to use these settings. > > Signed-off-by: Andrew Gregory <[email protected]> > --- > > I saw the patch to hide the offending use of parallel_downloads after > I wrote this. I think it makes more sense to just make these > available to the front-end; we've already had one attempt to > parallelize xfercommand. > As the author of said patch your fix seems better IMHO. The only thing I'd suggest is adding a Fixes-style reference for the "offending" commit. Here and for other patches in this series.
Thanks -Emil P.S. Didn't see the gitlab-ci.yml until Allan mentioned. Props for keeping an eye on the results.
