On Wed, Feb 24, 2021 at 10:57:47PM +1000, Allan McRae wrote: > On 22/2/21 9:09 am, Morten Linderud wrote: > > From: Morten Linderud <[email protected]> > > + # if no key was found, fall back to using the keyservers (with > > the key fingerprint instead) > > + if (( $? )) && ! "${GPG_PACMAN[@]}" --refresh-keys "$id"; then > > + error "$(gettext "The following key could not be > > updated from WKD or keyserver: %s")" "$id" > > This error message is verbose. "The following key..." is not needed. > It would be strange if we listed the key id not associated with the > message! And the user does not care that both WKD and keyserver failed, > just that there is a failure. > > How about: > > error "$(gettext "Could not update key: %s") "$id"
Ack! Looks good to me! -- Morten Linderud PGP: 9C02FF419FECBE16
signature.asc
Description: PGP signature
