On Fri, 2021-04-16 at 13:08 -0700, Andrew Gregory wrote: > On 04/16/21 at 03:42pm, Mark Weiman wrote: > > On Linux, signal.h is not required to have access to the signal > > constants. On FreeBSD, this is not the case and requires signal.h to be > > explicitly included. > > > > This patch checks if SIGINT can be used without signal.h and if not, > > make sure its included in the files that need it. > > No need for the check; just include signal.h wherever we use it.
Along with the suggested changes, since FreeBSD (and others) typically use clangas the C compiler of choice, a lot of warnings get tossed when compiling pacman.Would it be worth it to address clang warnings as long as it doesn't affect a normal GCC compilation? Mark
