Am 09.11.22 um 03:13 schrieb Allan McRae:
@Andrew (or anyone): the main patch I'd like another set of eyes on is: "Add sandboxed download for the internal downloader".
I've read it over and it looks mostly good to me. I did not build or test, just read the code. Two things I noticed are: - The "sandboxing failed" log message is a lot nicer in [1] than in [2] (line 995 in dload.c), maybe they should match? - Also, the `done = true` before the break in the first loop of the parent might be redundant (line 1026 in dload.c [3]), since `done` isn't used after the loop. Maybe even all `done=true` could be breaks, as no loop code runs after them anyway? [1]: https://gitlab.archlinux.org/pacman/pacman/-/commit/edb1d8e629a9b7a928bbb00c96381f4de995d322 [2]: https://gitlab.archlinux.org/pacman/pacman/-/commit/03e2e487e341aed137f3f124756d32081f1912a6#0ca666c951f4e0ee3d6c62b3044878997523490e_943_990 [3]: https://gitlab.archlinux.org/pacman/pacman/-/commit/03e2e487e341aed137f3f124756d32081f1912a6#0ca666c951f4e0ee3d6c62b3044878997523490e_943_1027 -- regards, brainpower
OpenPGP_signature
Description: OpenPGP digital signature
